Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Boolean parameters #92

Open
kingjon3377 opened this issue Aug 16, 2021 · 1 comment
Open

Reduce Boolean parameters #92

kingjon3377 opened this issue Aug 16, 2021 · 1 comment
Labels
enhancement

Comments

@kingjon3377
Copy link
Owner

Per Mortoray's persuasive post, throughout, work to replace Boolean method parameters with enums or other patterns where possible.
@kingjon3377
Copy link
Owner Author

And some Boolean return values as well.

  • Checks in MapCheckerCLI should return the list of warnings and let the caller decide what to do with them, not take Warning and return Boolean.
  • Fixtures' copy methods, and wrappers around them.
  • DriverUsage.graphical; we can maybe take this opportunity to stop showing --gui and --cli for subcommands that are only one or the other. Also includeInCLIList.
  • DirectionSelectionChanger mode.
  • auto parameters in ICLIHelper
  • Grove.orchard and Grove.cultivated
  • Expert mentoring flag in advancement apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kingjon3377