You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[SerializeField]
string value;
public string Value { get {return value; } set { value = value;} }
Making that value never get assigned. I would suggest adding changing setter to this.value = value to avoid ambiguity.
The text was updated successfully, but these errors were encountered:
WeAthFoLD
changed the title
If row value is named value, the import value will not get assigned
If column name is value, the import value will not get assigned
Oct 23, 2018
I'd argue that it's confusing to consider in the context of an excel sheet, that value is an keyword. It's valid in the world of C#, but spreadsheets has nothing to do with C#.
Furthermore, value is a contextual keyword, which means it's only considered a keyword in getter/setters. If we fix on the idea that column shouldn't be C# keyword, then it also can't be for,while,if,else, and so many others, which is IMO very weird.
Oops, I totally misunderstood the context. Yes, right. Even it seems to be no harm.
Would you like to change the code and do merge request, if you don't mind? Please, see the WriteProperty method in ScriptGenerator.cs file. There is where the change should be done. Thanks in advance.
Say I got a excel sheet like
The code generated for the
value
row would beMaking that value never get assigned. I would suggest adding changing setter to
this.value = value
to avoid ambiguity.The text was updated successfully, but these errors were encountered: