Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different license for translations #1

Closed
rob006 opened this issue Jul 11, 2021 · 4 comments
Closed

Different license for translations #1

rob006 opened this issue Jul 11, 2021 · 4 comments

Comments

@rob006
Copy link

rob006 commented Jul 11, 2021

Recently I'm trying to cleanup licenses mess for translations repository and your extension is main fuckup I've made - I copied translations from your repository, even if license strictly forbids this. Could you consider using different license for translation files, so they could be safely used in Weblate and language packs?

@rob006
Copy link
Author

rob006 commented Jul 12, 2021

Related: extiverse/premium-translations#3

@clarkwinkelmann
Copy link
Member

Sorry I missed this discussion.

I'm not sure how to mark this in the repository but the same conditions that were discussed for premium extensions can be ported to this extension, I have no issue with translators packaging translations for this extension as MIT.

This extension however might create further issues since the translation namespace doesn't adhere to Flarum naming convention 😇 The same namespace is used for free and pro (and free contains all the translations from pro even if some aren't used)

So technically even if you weren't allowed to copy these translations, Extiverse allows copying those from the pro extension and since they are the same that would work as well.

Do you think I should add a special license file inside of the locales folder?

@rob006
Copy link
Author

rob006 commented Jul 21, 2021

This extension however might create further issues since the translation namespace doesn't adhere to Flarum naming convention innocent The same namespace is used for free and pro (and free contains all the translations from pro even if some aren't used)

I don't think it would be a problem. Flarum loads files only for enabled extensions based on file name, so there should be no collisions (unless you have them both enabled, but it should not hurt in that case either).

Do you think I should add a special license file inside of the locales folder?

Adding MIT license file here would clear any doubts in this matter, so I would prefer to just add it.

@clarkwinkelmann
Copy link
Member

I have made the changes, the YAML file are now officially MIT licensed.

But it's still perfectly fine by me to reproduce the translation files even without retaining the license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants