Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refacto repo archi #1392

Conversation

theodu
Copy link
Contributor

@theodu theodu commented Aug 21, 2023

No description provided.

@theodu theodu force-pushed the feature/ml-1318-aau-on-the-sdk-when-i-look-at-the-code-i-see-the-backbone-of branch from f7a8bd9 to 1b97dce Compare August 21, 2023 14:21
@theodu theodu changed the title Feature/ml 1318 aau on the sdk when i look at the code i see the backbone of feat: refacto repo archi Aug 21, 2023
@theodu theodu force-pushed the feature/ml-1318-aau-on-the-sdk-when-i-look-at-the-code-i-see-the-backbone-of branch from 7f7ee10 to 45adc9e Compare August 21, 2023 14:56
@theodu theodu force-pushed the feature/ml-1318-aau-on-the-sdk-when-i-look-at-the-code-i-see-the-backbone-of branch from 45adc9e to 1f21de6 Compare August 21, 2023 15:21
@Jonas1312
Copy link
Contributor

can you fix the conflicts before I start the review? thx

@theodu theodu requested review from Jonas1312 and removed request for Jonas1312 August 22, 2023 12:47
tests/e2e/test_e2e_client.py Outdated Show resolved Hide resolved
tests/e2e/test_json_response_validation.py Outdated Show resolved Hide resolved
tests/services/test_issues.py Outdated Show resolved Hide resolved
@theodu theodu force-pushed the feature/ml-1318-aau-on-the-sdk-when-i-look-at-the-code-i-see-the-backbone-of branch from a418bbb to ec8e961 Compare August 24, 2023 09:49
@theodu theodu force-pushed the feature/ml-1318-aau-on-the-sdk-when-i-look-at-the-code-i-see-the-backbone-of branch 2 times, most recently from 2dddf52 to 41496b8 Compare August 24, 2023 12:01
@theodu theodu force-pushed the feature/ml-1318-aau-on-the-sdk-when-i-look-at-the-code-i-see-the-backbone-of branch from 41496b8 to 21e91ee Compare August 24, 2023 12:01
@theodu theodu requested a review from Jonas1312 August 24, 2023 12:01
@theodu
Copy link
Contributor Author

theodu commented Aug 24, 2023

@Jonas1312 @PierreLeveau La on arrive vers quelque chose de pas mal je trouve. vous pouvez rereview

docs/sdk/issue.md Show resolved Hide resolved
src/kili/gateways/kili_api_gateway/__init__.py Outdated Show resolved Hide resolved
src/kili/gateways/kili_api_gateway/issue/__init__.py Outdated Show resolved Hide resolved
src/kili/gateways/kili_api_gateway/issue/operations.py Outdated Show resolved Hide resolved
src/kili/use_cases/issue/__init__.py Outdated Show resolved Hide resolved
src/kili/use_cases/issue/__init__.py Outdated Show resolved Hide resolved
theodu added 2 commits August 24, 2023 17:44
@theodu theodu requested a review from Jonas1312 August 24, 2023 15:47
src/kili/presentation/client/issue.py Outdated Show resolved Hide resolved
src/kili/use_cases/issue/__init__.py Outdated Show resolved Hide resolved
@theodu theodu requested a review from PierreLeveau August 28, 2023 14:38
@theodu theodu merged commit cf5c24b into main Aug 28, 2023
11 checks passed
@theodu theodu deleted the feature/ml-1318-aau-on-the-sdk-when-i-look-at-the-code-i-see-the-backbone-of branch August 28, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants