Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the gradle files accordingly, to make it compilable on latest Android Studio #49

Merged
merged 2 commits into from
Feb 6, 2020

Conversation

elye
Copy link
Contributor

@elye elye commented Feb 1, 2020

Update the gradle files accordingly, to make it compilable on latest Android Studio 3.5.3

Note: I can't compile the Benchmark, as looks like it require NDK Compilation, as pointed in #45.

@kikoso kikoso changed the base branch from master to develop February 3, 2020 14:21
@kikoso kikoso self-requested a review February 3, 2020 14:24
@kikoso
Copy link
Owner

kikoso commented Feb 3, 2020

Hi @elye.

This PR is partially covered by this commit in develop (I have to specify the contribution guidelines, ideally the contributions should go into develop, and then develop gets merged into master when it is stable).

I have changed the base branch, and solve the conflicts. Any comments on them?

@kikoso kikoso merged commit 06e8307 into kikoso:develop Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants