You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So imho the behaviour of this library should be adjusted. But it is slightly problematic I think;
enabling colors on Windows by default is breaking behaviour
on Posix it is assumed that the caller of the library wants to use colors (since there are no checks whatsoever, eg using an isapty function to detect a pty)
so enabling color by default on Windows would make sense... though support for it might not be enabled...
So I see 2 options:
follow Posix behaviour and enable colors by default, if the caller doesn't want colors, then just don't use the lib.
Caller is responsible for proper checks and balances, as well as setup.
Lines up best with the Posix behaviour
breaking
enable colors, but make the calls to enable color support (using an external lib to call setconsolemode or use the os.execute workaround.
Doing the setup for the caller.
less breaking
Responsibilities are different from Posix (since caller doesn't do the setup)
wdyt?
The text was updated successfully, but these errors were encountered:
Windows has gained suppprt for ANSI sequences (since 2019, a specific release of 2010 added it).
setconsolemode()
can be used to enable itos.execute
as a workaroundSo imho the behaviour of this library should be adjusted. But it is slightly problematic I think;
isapty
function to detect a pty)So I see 2 options:
setconsolemode
or use theos.execute
workaround.wdyt?
The text was updated successfully, but these errors were encountered: