From 165b13ad3cddec3cf4cbe1d7820bd62409d13180 Mon Sep 17 00:00:00 2001 From: Sergi Romeu Date: Fri, 22 Nov 2024 13:29:37 +0100 Subject: [PATCH] [Inventory] Remove `Actions` tooltip (#201231) ## Summary Closes https://github.com/elastic/kibana/issues/199500 This PR removes the Actions tooltip in the Entities Table. ## Screenshots | Before | After | |-------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------| |![image](https://github.com/user-attachments/assets/c661245a-7d07-4203-b832-a59acc20259c)|image| ## How to test 1. Go to Inventory 2. Check the columns of the Entities table, the tooltip + help button should now be gone. (cherry picked from commit 62fad394e131e3629e1252cb6d28b9df8eff004b) --- .../public/components/entities_grid/grid_columns.tsx | 4 +--- .../inventory/public/components/entities_grid/index.tsx | 6 +++--- x-pack/plugins/translations/translations/fr-FR.json | 4 ++-- x-pack/plugins/translations/translations/ja-JP.json | 4 ++-- x-pack/plugins/translations/translations/zh-CN.json | 4 ++-- 5 files changed, 10 insertions(+), 12 deletions(-) diff --git a/x-pack/plugins/observability_solution/inventory/public/components/entities_grid/grid_columns.tsx b/x-pack/plugins/observability_solution/inventory/public/components/entities_grid/grid_columns.tsx index be5c50eba9c07..867425b9e0aed 100644 --- a/x-pack/plugins/observability_solution/inventory/public/components/entities_grid/grid_columns.tsx +++ b/x-pack/plugins/observability_solution/inventory/public/components/entities_grid/grid_columns.tsx @@ -116,9 +116,7 @@ export const getColumns = ({ id: 'actions' as const, // keep it for accessibility purposes displayAsText: entityActionsLabel, - display: ( - - ), + display: {entityActionsLabel}, initialWidth: 100, }, ] diff --git a/x-pack/plugins/observability_solution/inventory/public/components/entities_grid/index.tsx b/x-pack/plugins/observability_solution/inventory/public/components/entities_grid/index.tsx index ff4329955773d..dd421d30a3a9c 100644 --- a/x-pack/plugins/observability_solution/inventory/public/components/entities_grid/index.tsx +++ b/x-pack/plugins/observability_solution/inventory/public/components/entities_grid/index.tsx @@ -160,7 +160,7 @@ export function EntitiesGrid({ @@ -169,10 +169,10 @@ export function EntitiesGrid({ ), total: entities.length, - boldEntites: ( + boldEntities: ( {i18n.translate( - 'xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites', + 'xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities', { defaultMessage: 'Entities' } )} diff --git a/x-pack/plugins/translations/translations/fr-FR.json b/x-pack/plugins/translations/translations/fr-FR.json index 6614cda16d32d..5a82fd7c5d43e 100644 --- a/x-pack/plugins/translations/translations/fr-FR.json +++ b/x-pack/plugins/translations/translations/fr-FR.json @@ -26198,8 +26198,8 @@ "xpack.inventory.entitiesGrid.euiDataGrid.alertsTooltip": "Le nombre d'alertes actives", "xpack.inventory.entitiesGrid.euiDataGrid.entityNameLabel": "Nom de l'entité", "xpack.inventory.entitiesGrid.euiDataGrid.entityNameTooltip": "Nom de l'entité (entity.displayName)", - "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "Affichage de {currentItems} sur {total} {boldEntites}", - "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites": "Entités", + "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "Affichage de {currentItems} sur {total} {boldEntities}", + "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities": "Entités", "xpack.inventory.entitiesGrid.euiDataGrid.inventoryEntitiesGridLabel": "Grille des entités d'inventaire", "xpack.inventory.entitiesGrid.euiDataGrid.lastSeen": "{date} à {time}", "xpack.inventory.entitiesGrid.euiDataGrid.lastSeenLabel": "Vu en dernier", diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json index 7240953e3ddc5..bad76be93aab6 100644 --- a/x-pack/plugins/translations/translations/ja-JP.json +++ b/x-pack/plugins/translations/translations/ja-JP.json @@ -26170,8 +26170,8 @@ "xpack.inventory.entitiesGrid.euiDataGrid.alertsTooltip": "アクティブなアラートの件数", "xpack.inventory.entitiesGrid.euiDataGrid.entityNameLabel": "エンティティ名", "xpack.inventory.entitiesGrid.euiDataGrid.entityNameTooltip": "エンティティの名前（entity.displayName）", - "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "{currentItems}/{total}個の{boldEntites}を表示中", - "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites": "エンティティ", + "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "{currentItems}/{total}個の{boldEntities}を表示中", + "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities": "エンティティ", "xpack.inventory.entitiesGrid.euiDataGrid.inventoryEntitiesGridLabel": "インベントリエンティティグリッド", "xpack.inventory.entitiesGrid.euiDataGrid.lastSeen": "{date} @ {time}", "xpack.inventory.entitiesGrid.euiDataGrid.lastSeenLabel": "前回の認識", diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json index d947256ce289f..94fafe69edbbe 100644 --- a/x-pack/plugins/translations/translations/zh-CN.json +++ b/x-pack/plugins/translations/translations/zh-CN.json @@ -26226,8 +26226,8 @@ "xpack.inventory.entitiesGrid.euiDataGrid.alertsTooltip": "活动告警计数", "xpack.inventory.entitiesGrid.euiDataGrid.entityNameLabel": "实体名称", "xpack.inventory.entitiesGrid.euiDataGrid.entityNameTooltip": "实体的名称 (entity.displayName)", - "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "正在显示 {currentItems} 个（共 {total} 个）{boldEntites}", - "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entites": "实体", + "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft": "正在显示 {currentItems} 个（共 {total} 个）{boldEntities}", + "xpack.inventory.entitiesGrid.euiDataGrid.headerLeft.entities": "实体", "xpack.inventory.entitiesGrid.euiDataGrid.inventoryEntitiesGridLabel": "库存实体网格", "xpack.inventory.entitiesGrid.euiDataGrid.lastSeen": "{date} @ {time}", "xpack.inventory.entitiesGrid.euiDataGrid.lastSeenLabel": "最后看到时间",