-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make spec.version
required in Kiali CR and OSSMConsole CR
#7741
Labels
enhancement
This is the preferred way to describe new end-to-end features.
requires docs PR
Requires kiali.io or other documentation updates
requires helm chart PR
requires operator PR
It requires update in operator code
Comments
jmazzitelli
added
the
enhancement
This is the preferred way to describe new end-to-end features.
label
Sep 12, 2024
Note that we will still support the literal value |
jmazzitelli
added a commit
to jmazzitelli/kiali-operator
that referenced
this issue
Sep 12, 2024
jmazzitelli
added a commit
to jmazzitelli/helm-charts
that referenced
this issue
Sep 12, 2024
This was referenced Sep 12, 2024
jmazzitelli
added a commit
to jmazzitelli/kiali-operator
that referenced
this issue
Sep 12, 2024
jmazzitelli
added a commit
to jmazzitelli/kiali-operator
that referenced
this issue
Sep 13, 2024
jmazzitelli
added a commit
to jmazzitelli/kiali.io
that referenced
this issue
Sep 16, 2024
jmazzitelli
added a commit
to jmazzitelli/kiali-operator
that referenced
this issue
Sep 16, 2024
jmazzitelli
added
requires operator PR
It requires update in operator code
requires helm chart PR
requires docs PR
Requires kiali.io or other documentation updates
labels
Sep 16, 2024
all PRs closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
This is the preferred way to describe new end-to-end features.
requires docs PR
Requires kiali.io or other documentation updates
requires helm chart PR
requires operator PR
It requires update in operator code
Now that we have many versions of Kiali, and OSSMC and backstage plugins, and they support different versions of Istio and each other, confusion is rampant among users :)
This is because if
spec.version
is not specified in the CRs, a default version is selected by the operator, and that version might not be compatible with the user's Istio or other Kiali components.We need to make
spec.version
required. If not specified, the operator should immediately fail, and put a good error message in the status field of the CR letting the user know what they have to do.The text was updated successfully, but these errors were encountered: