Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateDef does not accept string argument for newvariance #93

Closed
kgoldfeld opened this issue Mar 4, 2021 · 3 comments · Fixed by #96
Closed

updateDef does not accept string argument for newvariance #93

kgoldfeld opened this issue Mar 4, 2021 · 3 comments · Fixed by #96
Assignees
Labels

Comments

@kgoldfeld
Copy link
Owner

updateDef with newvariance as a string returns an error

@kgoldfeld kgoldfeld added the bug label Mar 4, 2021
@assignUser
Copy link
Collaborator

This seems to be an issue with coercion of data types be dt. It only seems to happen when the previous variance was numeric and the new is character.

Looking into this I found that this function does not update the definition in place but returns the new one, this goes back to #50 so I guess we keep it this way but I will update the documentation/examples to make clear that you have to reassign the return to get the updated definition :)

@assignUser assignUser self-assigned this Apr 25, 2021
@assignUser
Copy link
Collaborator

We should also rewrite this to use the new assert system but as we also have #65 and #18 going it would make sense to postpone that for now.

@assignUser
Copy link
Collaborator

This also happens with all elements of the definition if they were initially numeric and the updated is a string. I think the best way to fix this would be to change the type of all def columns to character during creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants