From 6a45d7a86d83e3e2b45a12bd09c2bb7195984f14 Mon Sep 17 00:00:00 2001 From: Charles Dang Date: Mon, 20 Apr 2020 08:29:15 +1100 Subject: [PATCH 1/2] Document the file field crash issue on node 13 --- packages/fields/src/types/File/README.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/fields/src/types/File/README.md b/packages/fields/src/types/File/README.md index 1a4088a407e..951815b34e4 100644 --- a/packages/fields/src/types/File/README.md +++ b/packages/fields/src/types/File/README.md @@ -8,6 +8,14 @@ title: File Support files hosted in a range of different contexts, e.g. in the local filesystem, or on a cloud based file server. +> **Important:** As of this writing (April 2020), an upstream [issue](https://github.com/apollographql/apollo-server/issues/3508) with `apollo-server`'s dependencies can cause a server crash if using this field (regardless of adapter) with **Node 13 only**. To work around this, use Node 12 or below _or_ add the following to your `package.json`: +> +> ```js title=package.json +> "resolutions": { +> "graphql-upload": "^10.0.0" +> } +> ``` + ## Usage ```js From 2a37bf482ae4a44988c2ec692054880bfb493f54 Mon Sep 17 00:00:00 2001 From: Charles Dang Date: Mon, 20 Apr 2020 08:49:54 +1100 Subject: [PATCH 2/2] Added link to the GH issue --- packages/fields/src/types/File/README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/fields/src/types/File/README.md b/packages/fields/src/types/File/README.md index 951815b34e4..85a8210492a 100644 --- a/packages/fields/src/types/File/README.md +++ b/packages/fields/src/types/File/README.md @@ -8,13 +8,15 @@ title: File Support files hosted in a range of different contexts, e.g. in the local filesystem, or on a cloud based file server. -> **Important:** As of this writing (April 2020), an upstream [issue](https://github.com/apollographql/apollo-server/issues/3508) with `apollo-server`'s dependencies can cause a server crash if using this field (regardless of adapter) with **Node 13 only**. To work around this, use Node 12 or below _or_ add the following to your `package.json`: +> **Important:** As of this writing (April 2020), an upstream [issue](https://github.com/apollographql/apollo-server/issues/3508) with `apollo-server`'s dependencies can cause a server crash when using this field (regardless of adapter) with **Node 13 only**. To work around this, use Node 12 or below _or_ add the following to your `package.json`: > > ```js title=package.json > "resolutions": { > "graphql-upload": "^10.0.0" > } > ``` +> +> You can track this issue [here](https://github.com/keystonejs/keystone/issues/2101). ## Usage