This repository has been archived by the owner on Feb 12, 2019. It is now read-only.
keybase-redirector doesn't die/reload after run_keybase #1510
Labels
Comments
|
Success! Your log ID is: 7241292499e970e279ca531c |
|
Thanks, I'll look into it tomorrow. |
|
Anything else you need from me or testing subsequent releases, let me know. |
|
No I'm good, just busy. lots of issues came in this weekend. This one is still in my queue, will get to it as soon as I can. |
strib
added a commit
that referenced
this issue
Mar 14, 2018
Having an entry here will prevent other mounts from mounting over it, since it will be non-empty. That means future `run_keybase` calls won't keep spinning up new redirector processes, due to the fact that the running-as-root mount process sees an empty mountpoint. For now, I just did the simplest thing: a symlink called "KBFS_NOT_RUNNING" that points to /dev/null. In the future, it might be nice to have it point to a README file somewhere on disk, but that would be a bigger undertaking. Issue: #1510
strib
added a commit
that referenced
this issue
Mar 14, 2018
Having an entry here will prevent other mounts from mounting over it, since it will be non-empty. That means future `run_keybase` calls won't keep spinning up new redirector processes, due to the fact that the running-as-root mount process sees an empty mountpoint. For now, I just did the simplest thing: a symlink called "KBFS_NOT_RUNNING" that points to /dev/null. In the future, it might be nice to have it point to a README file somewhere on disk, but that would be a bigger undertaking. Issue: #1510
|
Should be fixed with #1511. Thanks for the report! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
On Debian/Ubuntu Linux, subsequent runnings of
run_keybaseresults in more than onekeybase-redirector.Either the restart does not kill the child process or it just doesn't get cleaned up. No noticable performance issues, but could be problematic. Could it be because it is run as root and
run_keybaseis as a normal user?rmday@cacodaemon:~$ ps -aux |grep keybase-redirector root 7870 0.0 0.0 759336 4592 ? Sl 09:33 0:00 keybase-redirector /keybase root 8155 0.0 0.0 685348 4260 ? Sl 09:33 0:00 keybase-redirector /keybase root 8383 0.0 0.0 609952 4304 ? Sl 09:34 0:00 keybase-redirector /keybase rmday 8819 0.0 0.0 14352 1068 pts/4 R+ 09:38 0:00 grep --color=auto keybase-redirectorAttaching log shortly.
The text was updated successfully, but these errors were encountered: