Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delphes TrkCov matrix updated #77

Open
andresailer opened this issue May 8, 2022 · 2 comments
Open

Delphes TrkCov matrix updated #77

andresailer opened this issue May 8, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@andresailer
Copy link

  • Was released in delphes (3.5.0)
    • How to ensure the correct TrkCov is used? require delphes 3.5.0 and above
      • Add a check for version
@andresailer andresailer added the enhancement New feature or request label May 8, 2022
@tmadlener
Copy link
Contributor

tmadlener commented May 9, 2022

Delphes doesn't export any easy to use version to the outside. What is in place currently here is the detection of the TrkCov header file:

# Delphes does not offer an obvious version indicator, but we need to know
# whether the TrackCovariance module is available or not. So here we simply
# check whether the corresponding header is installed
find_file(DELPHES_TRACK_COV_HEADER modules/TrackCovariance.h PATHS ${DELPHES_INCLUDE_DIRS} NO_DEFAULT_PATHS)

Obviously with this we can not differentiate between 3.5.0 and the various pre versions. I seem to remember that we at some point decided to drop all support for the pre versions and simply assume that the presence of the covariance matrix ensures >= 3.5.0

@andresailer
Copy link
Author

We should ask for or add feature that Delphes exports its version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants