Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate matching broken after [email protected] #52

Closed
tmadlener opened this issue May 26, 2021 · 2 comments
Closed

Candidate matching broken after [email protected] #52

tmadlener opened this issue May 26, 2021 · 2 comments

Comments

@tmadlener
Copy link
Contributor

The tests comparing the edm4hep and delphes outputs are broken with the current delphes master. Some bisecting points to this commit where things start to break (tested with [email protected]/06 and [email protected]/00). The tests break with something along the lines:

[...] lots of the following

**** WARNING: No matching ReconstructedParticle was found for a Jet constituent
**** WARNING: No matching ReconstructedParticle was found for a Jet constituent
**** WARNING: No matching ReconstructedParticle was found for a Jet constituent
**** WARNING: No matching ReconstructedParticle was found for a Delphes muon
**** WARNING: No matching ReconstructedParticle was found for a Jet constituent
**** WARNING: No matching ReconstructedParticle was found for a Jet constituent
**** WARNING: No matching ReconstructedParticle was found for a Jet constituent

[...] and then further down

EVENT: 0
MC relations of candidate 0 are different between delphes and edm4hep output
+ seeds_file_cleanup
+ cat /home/tmadlener/work/k4SimDelphes/build_root_6.24.00/tests/random_seeds.2JdYYVG5
RANDOM SEED FOR DELPHES CARD = 5515
RANDOM SEED FOR PYTHIA CMD = 4435

So basically the comparison fails at the first element already.

Previously there were 0 warnings for No matching ReconstructedParticle was found for a Jet constituent and essentially 0 for Delphes muons (the ones that appear are probably related to #48). After the commit mentioned above, it seems that not a single candidate can be matched any longer. From the diff in the commit it is not immediately clear to me why the candidate matching breaks so badly.

Additionally, the matching seems to be completely broken with [email protected]/08, or at least I cannot even find a good commit to start bisecting on with that version (e.g. 3.4.3pre10 works with 6.22/06 and 6.24/00 but not with 6.22/08).

@tmadlener
Copy link
Contributor Author

With the fixes in delphes also [email protected]/08 seems to be working fine again. Once this is fixed in delphes this can be closed.

@tmadlener
Copy link
Contributor Author

Fixed in delphes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant