Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion: Do we want a basic pre-commit workflow in the project-template? #10

Open
tmadlener opened this issue Mar 3, 2022 · 0 comments
Open

Discussion: Do we want a basic pre-commit workflow in the project-template? #10

tmadlener opened this issue Mar 3, 2022 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@tmadlener
Copy link
Contributor

If so what do we want to want to run with it?

Easily available hooks from upstream pre-commit

  • mixed-line-ending
  • trailing-whitespace

Hooks that are easy to integrate on top of e.g. a bare LCG release (usually just need a suitable python version and some LLVM tools + cmake)

  • pylint (+ config)
  • flake8
  • clang-format
  • clang-tidy

For some of these upstream hooks exist but they are usually locked to a given version of e.g. clang/LLVM.
@tmadlener tmadlener added enhancement New feature or request question Further information is requested labels Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tmadlener