Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spread operator issue on some browsers #62

Open
mike-weshop opened this issue Apr 24, 2019 · 1 comment
Open

Spread operator issue on some browsers #62

mike-weshop opened this issue Apr 24, 2019 · 1 comment

Comments

@mike-weshop
Copy link

Since the update to release 5.0.0 - the spread operator at
https://github.com/kevva/url-regex/blob/master/index.js#L8
is causing issues in some browsers which don't support that. even though node handles it, javascript fails in certain older browsers.

Could the spread operator be reverted back to Object.assign since it's only used in 1 place and would work on all browsers then?

teleaziz pushed a commit to teleaziz/url-regex that referenced this issue Aug 13, 2019
teleaziz pushed a commit to teleaziz/url-regex that referenced this issue Aug 13, 2019
teleaziz pushed a commit to teleaziz/url-regex that referenced this issue Aug 13, 2019
@niftylettuce
Copy link
Collaborator

This issue is fixed in my maintained and modern version of this package at https://github.com/niftylettuce/url-regex-safe. You should be able to switch from url-regex to url-regex-safe now. See the updated list of options as I added some new ones, and changed a few defaults to more sensible ones (since not everyone is parsing Markdown for instance).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants