Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matching non existent tld #57

Open
CheweyZ opened this issue Jun 27, 2018 · 3 comments
Open

matching non existent tld #57

CheweyZ opened this issue Jun 27, 2018 · 3 comments

Comments

@CheweyZ
Copy link

CheweyZ commented Jun 27, 2018

running urlRegex({strict: false}).test('something github.are foo bar');
returns true even though "are" isnt on the list of tld's
image

@mathieumg
Copy link

But .ar is and it matches github.ar, although it shouldn't.

@yzaroui
Copy link

yzaroui commented Apr 23, 2019

Well, even worse, when given 'bonjour.bonsoir' it matches bonjour.bo

@niftylettuce
Copy link
Collaborator

See my comment in #67 and my new package at https://github.com/niftylettuce/url-regex-safe. We cannot add the fix mentioned in the PR because it is a security vulnerability (as it would not allow us to use RE2 due to the described error thrown).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants