Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkdir tmp instead of keys #5

Open
SalesforceRocks opened this issue Nov 1, 2017 · 0 comments
Open

mkdir tmp instead of keys #5

SalesforceRocks opened this issue Nov 1, 2017 · 0 comments

Comments

@SalesforceRocks
Copy link

SalesforceRocks commented Nov 1, 2017

Hi,

Great work! There is however a little error I think in the circle.yml and there is some room for improvement.

Error:
You create a tmp dir. Shouldn't that be keys? The build fails otherwise.

Improvement:
Installing sfdx can be done now by the following (old lines commented):

#- wget -qO- $DX_CLI_URL | tar xJf -
#- ./sfdx/install
- npm install -g npm
- npm install --global sfdx-cli

The reason why you have to update npm is because CircleCI 1.0 has an old npm version installed. Before you can upgrade npm however you have to update node as well. So add this directly under the machine statement:

machine:
  node:
    version: 8.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant