Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] run_dr_methods breaks when the PyCytoData's channels have been subsetted #18

Open
kevin931 opened this issue May 28, 2024 · 1 comment · May be fixed by #22
Open

[BUG] run_dr_methods breaks when the PyCytoData's channels have been subsetted #18

kevin931 opened this issue May 28, 2024 · 1 comment · May be fixed by #22
Assignees
Labels
bug Something isn't working

Comments

@kevin931
Copy link
Owner

What issues are you experiencing?
When we've subset a dataset, the _lineage_channels_indices private attribute is not properly updated. This results in an index out of bound IndexError when running run_dr_methods method. This is a critical issue because in the case that the subsetting procedure does not result in an index out of bound error, then this is a insidious bug that won't surface.

To Reproduce

It's easy to reproduce with a built-in example:

from PyCytoData import DataLoader

exprs = DataLoader.load_dataset(dataset = "levine32", preprocess=True)
exprs = exprs.subset(channels = exprs.lineage_channels)
exprs.run_dr_methods(methods = ["UMAP"])

Expected behavior
We should internally update the indices so that it will not result in such bugs. We should have this resolved quickly and push out a patch because this is an actual bug rather than a documentation issue.

Your environment:

  • OS: Linux
  • Python Version: 3.11
  • Python Distribution: Anaconda
  • PyCytoData version: 0.1.2
  • PyCytoData distribution: Conda
@kevin931 kevin931 added the bug Something isn't working label May 28, 2024
@kevin931 kevin931 self-assigned this May 28, 2024
@kevin931
Copy link
Owner Author

Also, this bug persists when we manually set the lineage channels at a later stage. This needs to fixed at the setter.

@kevin931 kevin931 linked a pull request Sep 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant