Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluggy Reloaded: merge back Contrib/pkupper/BabelFish into Utils/BabelFish #165

Open
kervinck opened this issue Apr 5, 2020 · 0 comments

Comments

@kervinck
Copy link
Owner

kervinck commented Apr 5, 2020

It is undesirable to have forks of BabelFish all over the place.

What is holding back merging right now is relatively small:

Adaptations

A different indentation style is used for the modified sections:
Spaces after keywords such as if and while

A differences in naming convention. We also camelCase abbreviations:

GT1 --> Gt1
PS2 --> Ps2
Hence also:
doSDFileTransfer --> doSdFileTransfer

The readNext() macro disappeared, and that causes a hangup when sendFile gets interrupted. The point of the macro is to provide an escape back into the main loop in case of an aborted file transfer. Now this situation requires a reset by the user and is confusing. That's undesirable and should be avoided by the system again.

Testing

When resolving the above, the result must be tested on the supported platforms:
Arduino Uno, Arduino Micro, Arduino Nano
--> On each of those, test all functionality

  1. sendFile.py
  2. the commands in the command line interface
  3. the function key shortcuts in Loader
  4. Saving and loading into Tiny BASIC
  5. Saving and loading into MS BASIC

On at least one of each, test

  1. Game controller pass through
  2. PS/2 interface

ATTiny85
--> The resulting object file shouldn't change a single byte

** Wrap-up **

With that, the Pluggy Reloaded config can be added as a supported configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant