Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't use RTSP with UDP connection #135

Open
mvdberge opened this issue Feb 14, 2024 · 2 comments · May be fixed by #136
Open

Can't use RTSP with UDP connection #135

mvdberge opened this issue Feb 14, 2024 · 2 comments · May be fixed by #136
Assignees
@cedricve
Labels
enhancement New feature or request

Comments

@mvdberge
Copy link

Error in Web GUI: "server wants to use the UDP transport protocol"

The RTSP client is fixed to TCP connections, see this line:

agent/machinery/src/capture/gortsplib.go

Line 83 in 3f29d1c

transport := gortsplib.TransportTCP

I think this line could just be deleted, as the documentation of gortsplib says that it has an automatism to choose the right transport variant (see https://github.com/bluenviron/gortsplib/blob/2c05e2d3ea16ae15d2bbc5846c6d823e3bcaed39/client.go#L228C1-L231C22):

        // transport protocol (UDP, Multicast or TCP).
        // If nil, it is chosen automatically (first UDP, then, if it fails, TCP).
        // It defaults to nil.
        Transport *Transport
@mvdberge mvdberge linked a pull request Feb 14, 2024 that will close this issue
Open
@cedricve
Copy link
Member

I believe we might need an additional header to set/force TCP or UDP, but setting it to auto can give unwanted experiences. Let me know what you think @mvdberge

@cedricve cedricve added the enhancement New feature or request label Jul 4, 2024
@cedricve cedricve self-assigned this Jul 4, 2024
@cedricve
Copy link
Member

cedricve commented Jul 4, 2024

We'll add a method to choose for UDP, TCP or Auto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cedricve cedricve

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't tie RTSP client to TCP, allow UDP also (fixing #135) mvdberge/kerberos-io-agent
2 participants
@cedricve @mvdberge