Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow EarlyStopping to be reused between multiple fits. #20533

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

hertschuh
Copy link
Collaborator

@hertschuh hertschuh commented Nov 22, 2024

All values were already reset properly in on_train_begin except best.

Fixes #20521

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.12%. Comparing base (a93828a) to head (977e080).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20533   +/-   ##
=======================================
  Coverage   82.11%   82.12%           
=======================================
  Files         515      515           
  Lines       47806    47808    +2     
  Branches     7490     7491    +1     
=======================================
+ Hits        39258    39260    +2     
  Misses       6736     6736           
  Partials     1812     1812           
Flag Coverage Δ
keras 81.97% <100.00%> (+<0.01%) ⬆️
keras-jax 65.06% <100.00%> (+<0.01%) ⬆️
keras-numpy 60.04% <100.00%> (+<0.01%) ⬆️
keras-tensorflow 66.04% <100.00%> (+<0.01%) ⬆️
keras-torch 64.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

All values were already reset properly in `on_train_begin` except `best`.

Fixes keras-team#20521
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Nov 22, 2024
@fchollet fchollet merged commit 4e2e6e1 into keras-team:master Nov 22, 2024
7 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels Nov 22, 2024
@hertschuh hertschuh deleted the early_stopping branch November 22, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EarlyStopping instance is not reusable
4 participants