Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] centerMap causing an incorrect viewport #1499

Closed
GuyShaanan opened this issue May 31, 2021 · 2 comments
Closed

[Bug] centerMap causing an incorrect viewport #1499

GuyShaanan opened this issue May 31, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@GuyShaanan
Copy link

GuyShaanan commented May 31, 2021

Describe the bug
Using the following csv as example:

lon,lat
30,30
40,40

results in the points not being shown after csv is loaded, unless you zoom out a bit.
Something is not working correctly with the fit to bounds.
(Might be related to #1025 (although the issue there is already fixed))
(Edit: might not be kepler bug, but this? mapbox/geo-viewport#30)

To Reproduce
Steps to reproduce the behavior:

  1. Go to kepler.gl (Issue can be easily reproduced there, but also when using keper.gl 2.5.1 in React app)
  2. Add the above CSV to map (when using kepler.gl code, use centerMap: true)

Current behavior
The 2 points are not shown in viewport. You have to zoom out a bit to see them.
image

Expected behavior
The 2 points should be shown in viewport.
image

Desktop (please complete the following information):

  • OS: *
  • Browser: Chrome
  • Version 91
@GuyShaanan GuyShaanan added the bug Something isn't working label May 31, 2021
@heshan0131
Copy link
Contributor

heshan0131 commented Jun 7, 2021

Thanks for reporting this and attached the issue. PR is coming

@heshan0131
Copy link
Contributor

This should be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants