fix(utils): setup extension by format in getRollupOutput (maybe breaking-change) #244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Set build output file extension by target format.
Why:
testing-library/react-testing-library#1338
I looking for a solution to this issue.
First of all, the issue was different from
testing-library/dom
, which is referred to intesting-library/react
, andtesting-library/dom
, which is referred to intesting-library/user-event
.So I solved this problem by changing the extension of the esm file to
.mjs
.testing-library
was using that library as a build tool, and found out that within that library they were building extensions as fixed as.js
and are trying to fix it.Screenshot
Before change extension
After configure in
testing-library/react
, butgetConfig().eventWrapper
intesting-library/user-event
is default function.After change extension
After configure in
testing-library/react
, sogetConfig().eventWrapper
intesting-library/user-event
is configured function.How:
Set file extension string using format parameter.
Checklist: