Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using github team to define the list of reviewers instead of listening individual names #123

Open
itomtom opened this issue Mar 25, 2020 · 1 comment · May be fixed by #125
Open

Using github team to define the list of reviewers instead of listening individual names #123

itomtom opened this issue Mar 25, 2020 · 1 comment · May be fixed by #125

Comments

@itomtom
Copy link

itomtom commented Mar 25, 2020

Is your feature request related to a problem? Please describe.
Currently listing a Github team assigns the whole team to the pull request, when in reality what I am hoping for is individual members in the team to be assigned.

Describe the solution you'd like
Can we define the team name org/team and X number of reviewers will be chosen from the github team.

Describe alternatives you've considered
Listing each individual member in a org/team. But then you'll have multiple list of teams to maintain.

Additional context
I am not entirely sure if this is already available and I am just listing the team incorrectly in the auto_assign.yml. At the moment it assigned the whole team to the pull request, which is not exactly what I was looking for. I only needed two members in the team.
itomtom pushed a commit to itomtom/auto-assign that referenced this issue Apr 14, 2020
feat(reviewersInTeams): using teams to add reviews
a63a68d 
* Using GitHub teams you can specify reviewers to be added to Pull
Request
* GitHub team's slug name is used under the label reviewersInTeams to
extract the members in the team

Fixes kentaro-m#123
@itomtom itomtom linked a pull request Apr 14, 2020 that will close this issue
Open
itomtom pushed a commit to itomtom/auto-assign that referenced this issue Apr 21, 2020
feat(reviewersInTeams): using teams to add reviews
d7e792b 
* Using GitHub teams you can specify reviewers to be added to Pull
Request
* GitHub team's slug name is used under the label reviewersInTeams to
extract the members in the team

Fixes kentaro-m#123
@Crossedfall
Copy link

Crossedfall commented Apr 27, 2020 •
edited
Loading

Do you have the team set to auto assign? GitHub allows you to configure teams to automatically assign a set number of people to a PR, it'll even try to balance out the reviews for you.

https://help.github.com/en/github/setting-up-and-managing-organizations-and-teams/managing-code-review-assignment-for-your-team

Not sure if that's exactly what you're looking for, but it sounds pretty close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(reviewersInTeams): using teams to add reviews itomtom/auto-assign
2 participants
@itomtom @Crossedfall