Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observer is causing performance issues #67

Open
ondrejsevcik opened this issue Aug 14, 2018 · 3 comments
Open

Observer is causing performance issues #67

ondrejsevcik opened this issue Aug 14, 2018 · 3 comments

Comments

@ondrejsevcik
Copy link

Hi, I've noticed that using observer in the range-slider causes performance issues.

The problematic part is observer on start attribute. I think it's not necessary, because on didUpdateAttrs method calls update which updates start property as well.

I've tried to remove completely that observer and it solved the performance issue for me.

here is an working example https://ember-twiddle.com/d1cb52c73d07c0c016261c36000f5971?openFiles=templates.application.hbs%2C

Would you accept PR?
@scottkidder
Copy link
Contributor

I didn't notice any performance issues but I do agree that the observer is not necessary and should be removed.

@ondrejsevcik
Copy link
Author

perf-issue

this is how it behaves on my computer (Mac - FF and Chrome)

@scottkidder
Copy link
Contributor

Yeah, very noticeable. Can you prepare a PR?

@ondrejsevcik ondrejsevcik mentioned this issue Sep 18, 2018
Closed
scottkidder pushed a commit to scottkidder/ember-cli-nouislider that referenced this issue Sep 21, 2018
@ondrejsevcik @scottkidder
Remove observer
b6b1728 
It's not necessary as the value is
updated in didUpdateAttrs hook.

Should fix kennethkalmer#67
scottkidder pushed a commit to scottkidder/ember-cli-nouislider that referenced this issue Mar 27, 2019
@ondrejsevcik @scottkidder
Remove observer
484e05b 
It's not necessary as the value is
updated in didUpdateAttrs hook.

Should fix kennethkalmer#67
scottkidder pushed a commit to scottkidder/ember-cli-nouislider that referenced this issue Mar 27, 2019
@ondrejsevcik @scottkidder
Remove observer
eb16796 
It's not necessary as the value is
updated in didUpdateAttrs hook.

Should fix kennethkalmer#67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove observer
2 participants
@scottkidder @ondrejsevcik