Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveRecord::Base.configurations error after rails 7 upgrade #39

Open
xspaniki opened this issue Mar 28, 2023 · 6 comments
Open

ActiveRecord::Base.configurations error after rails 7 upgrade #39

xspaniki opened this issue Mar 28, 2023 · 6 comments

Comments

@xspaniki
Copy link

xspaniki commented Mar 28, 2023

Hello,

after I upgraded rails 7 this gem has problem with access to ActiveRecord::Base.configurations as to Hash object.

https://www.fastruby.io/blog/rails/upgrades/upgrade-rails-6-1-to-7-0.html

Problem is in lib/standby/connection_holder.rb in activate function. In PR is one pending to fix this (#38). Please can you update gem to work with rails 7? For now i forked repository but i would like to use gem directly.

Thanks !

@kenn
Copy link
Owner

kenn commented Mar 28, 2023

Pull request welcomed!

@xspaniki
Copy link
Author

@kenn here bro #40

@xspaniki
Copy link
Author

xspaniki commented Mar 29, 2023

ok it looks like i didnt check compatibility with older versions, so i have to check that

@kenn
Copy link
Owner

kenn commented Mar 29, 2023

Oops, I just merged so I'll be waiting for another PR, thanks a bunch @xspaniki !

@xspaniki
Copy link
Author

@kenn Im not sure why ruby 2.2 checks didnt pass but it looks like there some issue independent on my MR https://github.com/kenn/standby/actions/runs/4552218725

MR: #41

@y-shashank
Copy link

Anyone facing error connecting with obdc adapter ?
We are facing some issues with databricks and odbc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants