Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak when using the 'widget' option #250

Open
GothikX opened this issue Apr 5, 2018 · 0 comments
Open

Memory leak when using the 'widget' option #250

GothikX opened this issue Apr 5, 2018 · 0 comments

Comments

@GothikX
Copy link

GothikX commented Apr 5, 2018

When the 'widget' option is part of the options object in getWidget, it is passed directly to kendo, which makes a clone of it (via jquery.extend), effectively cloning the previous value of the observable previously bound to the widget option and keeping it in memory. Any time the binding is reinitialized, such as when the datasource is updated, the options object is wrapped again in this way causing this:

image
GothikX added a commit to GothikX/knockout-kendo that referenced this issue Apr 5, 2018
@GothikX
Fix for memory leak kendo-labs#250
bd3cb64 
options.widget shouldn't be passed to kendo in getWidget because kendo keeps a copy of the options, and repeated reinitialization of the widget will keep all previous instances of the widget
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GothikX