New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: awsprovider #294

Open

1 of 5 tasks

eytan-avisror opened this issue May 6, 2021 · 0 comments

Labels

Collaborator

eytan-avisror commented May 6, 2021 •

edited

Loading

We should do some refactoring on awsprovider to simplify it and make it a bit more maintainable.

Split aws.go into multiple files according to service - ec2.go, autoscaling.go etc.
Rename AwsWorker to AmazonClientSet
Move Mocks from eks_test.go to aws_test.go so that it can be shared by other packages, currently mock implementation is repetitive between packages
Remove any unused methods
Remove Parameters from struct -> may require refactoring of eksmanaged/fargate provisioner

The text was updated successfully, but these errors were encountered:

eytan-avisror added the refactor label

eytan-avisror mentioned this issue

refactor: awsprovider file restructure #296

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment