Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: Adding filter to workflow execution table cause refresh of the page #2025

Closed
shahargl opened this issue Sep 29, 2024 · 6 comments · Fixed by #2211
Closed

[🐛 Bug]: Adding filter to workflow execution table cause refresh of the page #2025

shahargl opened this issue Sep 29, 2024 · 6 comments · Fixed by #2211
Assignees

Comments

@shahargl
Copy link
Member

CleanShot.2024-09-29.at.13.55.06.mp4
@talboren
Copy link
Member

@rajeshj11 FYI: i think this was intentional as it fetches data from the backend (filtering happens in the backend)

@shahargl
Copy link
Member Author

@rajeshj11

even if true - there are only 3 filters ("static", "manual" and "alert") why not fetching them ahead?
second, in nextjs, only the table should refresh, not all the page (which takes more time to load). the problem is that it changes the URL and then router.push which is navigating to another page.

@rajesh-jonnalagadda
Copy link
Contributor

rajesh-jonnalagadda commented Sep 29, 2024

@shahargl @talboren
there are only 3 filters ("static", "manual" and "alert") . we can fetch but additional custom handling needs to be done at the frontend layer.

will work on the feedback/bug. please assign it to me.

  1. Instead of completely repainting the entire page, render only the necessary components.
  2. The selection of any option should not trigger a redirect; only the content on the right side should change.

@shahargl
Copy link
Member Author

assigned! 🤴

@rajesh-jonnalagadda
Copy link
Contributor

rajesh-jonnalagadda commented Sep 29, 2024

@shahargl How urgent is this? I committed to helping with the issue below. can I start after that is resolved?
#1780

@AMANCHAUBEY8822

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants