Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[➕ Feature]: Improve workflow validation #1885

Open
shahargl opened this issue Sep 9, 2024 · 12 comments
Open

[➕ Feature]: Improve workflow validation #1885

shahargl opened this issue Sep 9, 2024 · 12 comments
Assignees

Comments

@shahargl
Copy link
Member

shahargl commented Sep 9, 2024

  1. Today "id" is being used as an name. This behavior should be deprecated. If an id is supplied, use it, and use name as name https://github.com/keephq/keep/blob/main/keep/parser/parser.py#L37
  2. Deleting an workflow and creating another workflow with the same name shows again all old data since deleting a workflow make it is_deleted=1 and not really deletes the workflow (which is ok). Uploading a workflow without an id should generated different uuid.
  3. Improve validation - mark workflow with some flag that says it won't run (e.g. configuration error) until something will fix it
@rajesh-jonnalagadda
Copy link
Contributor

rajesh-jonnalagadda commented Sep 11, 2024

@shahargl I would like to work on this. can you please guide me on what are the improvements we need?

@shahargl
Copy link
Member Author

@rajeshj11 yes! updated ticket.

@rajesh-jonnalagadda
Copy link
Contributor

@shahargl Can we create two identical workflows?

@shahargl
Copy link
Member Author

/bounty 50

Copy link

algora-pbc bot commented Sep 19, 2024

💎 $50 bounty • Keep (YC W23)

Steps to solve:

  1. Start working: Comment /attempt #1885 with your implementation plan
  2. Submit work: Create a pull request including /claim #1885 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to keephq/keep!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🔴 @rajeshj11 Sep 19, 2024, 12:29:08 PM WIP
🟢 @35C4n0r Sep 24, 2024, 1:32:27 PM #2013

@rajesh-jonnalagadda
Copy link
Contributor

rajesh-jonnalagadda commented Sep 19, 2024

/attempt #1885

Algora profile Completed bounties Tech Active attempts Options
@rajeshj11    3 keephq bounties
+ 16 bounties from 7 projects
JavaScript, TypeScript,
HTML
Cancel attempt

@35C4n0r
Copy link
Contributor

35C4n0r commented Sep 24, 2024

@Matvey-Kuk is anyone working on this currently? I would like to attempt it.

@Matvey-Kuk
Copy link
Contributor

@35C4n0r it's yours!

@35C4n0r
Copy link
Contributor

35C4n0r commented Sep 24, 2024

/attempt #1885

Algora profile Completed bounties Tech Active attempts Options
@35C4n0r    18 keephq bounties
+ 12 bounties from 4 projects
Python, TypeScript,
HTML & more
﹟1771
Cancel attempt

@rajesh-jonnalagadda
Copy link
Contributor

rajesh-jonnalagadda commented Sep 26, 2024

/attempt #1885

Algora profile Completed bounties Tech Active attempts Options
@35C4n0r    18 keephq bounties

  • 12 bounties from 4 projects
    Python, TypeScript,
    HTML & more
    ﹟1771
    Cancel attempt

@35C4n0r I have already attempted the issue, and although I wasn't able to get my changes merged, I do have some context on the modifications. If needed any assistance on this feature. feel free to reach out to me. I am open to collaborate

@talboren
Copy link
Member

Can you please give this PR a better indicative name? 🙏🏼

@Matvey-Kuk
Copy link
Contributor

Payout for this bounty will be executed via GitHub Sponsors, not via Algora. Please activate https://github.com/sponsors/accounts for your account to receive the payout, sorry for the inconvenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants