-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete key passes through to database widget despite active modal dialog #11217
Comments
There are settings that require confirmation before deleting. The default behavior is to send entries to he database recycle bin. However, this doesn't make sense. The save as dialog is a modal dialog that captures all keyboard input and won't send any to the application. I also do not understand the difference an external keyboard would make. |
Despite my initial thoughts above, this is actually a bug. However I think this is a Qt bug in that focus is not properly delivered to the save as dialog. We can prevent this specific behavior from happening by ignoring delete actions when a modal dialog is active. |
Overview
KeePassXC 2.7.9 Mac with external Logitech Keyboard. You want to use "Save as" to save the database. In the Save As window, you left-click once and then use the Delete key on the external keyboard to delete a character. If you press the Delete key on the keyboard, this character will not be deleted. Instead, your database entry will be accidentally deleted in the background.
Steps to Reproduce
Expected Behavior
The character in the "Save as:" field is deleted
Actual Behavior
The selected entry in the background window will be deleted
Context
This only happens when I use an external keyboard. But I think I'm not the only one who uses an external keyboard, and accidentally deleting an entry in the background window is a critical behavior with unintended data loss.
It would be nice if there was a setting that required confirmation before deleting entries. This can prevent accidental deletion.
KeePassXC - 2.7.9
Revision: REVISION
Operating System: macOS
The text was updated successfully, but these errors were encountered: