Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when creating DB, don't make typed password visible #11212

Closed
ChristianS99 opened this issue Aug 30, 2024 · 3 comments · Fixed by #11321
Closed

when creating DB, don't make typed password visible #11212

ChristianS99 opened this issue Aug 30, 2024 · 3 comments · Fixed by #11321
Assignees
Milestone

Comments

@ChristianS99
Copy link

Summary

When creating a new database, the password prompt by default shows the password and it must be hidden by clicking on eye icon.
Since this is contrary to all other programs I use, it was (for me) very surprising, that the typed password is visible by default.
IMHO, it would be better, not to show typed pw by default, but hide it, and only show it when clicking on eye icon.

Examples

NA

Context

It's different from all other programs, where the pw is not visible and only shown, when something is clicked.
Typing pw and seeing it on screen afterwards was very surprising...

@droidmonkey
Copy link
Member

droidmonkey commented Aug 30, 2024

That is definitely not the current behavior. Make sure you are running version 2.7.9

@ChristianS99
Copy link
Author

that's the behaviour with current develop branch:

KeePassXC - Version 2.8.0-snapshot
Build-Typ: Snapshot
Revision: 48d0f2b

Qt 5.15.14
Diagnosemodus ist deaktiviert.

Betriebssystem: Gentoo Linux
CPU-Architektur: x86_64
Kernel: linux 6.10.3-gentoo-dist

Aktivierte Erweiterungen:
- Auto-Type

Kryptographische Bibliotheken:
- Botan 3.2.0

which i just tried, and previously I tried with 2.7.9:

KeePassXC - Version 2.7.9
Revision: 8f6dd13

Qt 5.15.14
Diagnosemodus ist deaktiviert.

Betriebssystem: Gentoo Linux
CPU-Architektur: x86_64
Kernel: linux 6.10.3-gentoo-dist

Aktivierte Erweiterungen:
- Browser-Integration
- Passkeys
- SSH-Agent
- KeeShare
- YubiKey
- Secret-Service-Integration

Kryptographische Bibliotheken:
- Botan 3.2.0

both builds have this behaviour. I started both with --config foo where foo is not existend, so (I hope) the default config is used to exclude local config changes.

@droidmonkey
Copy link
Member

My mistake, the password is actually visible by default in the new-password dialog.

@droidmonkey droidmonkey reopened this Aug 30, 2024
@droidmonkey droidmonkey added this to the v2.7.10 milestone Aug 30, 2024
@droidmonkey droidmonkey self-assigned this Aug 30, 2024
@github-project-automation github-project-automation bot moved this to To triage in WIP Tracker Sep 23, 2024
@droidmonkey droidmonkey moved this from In progress to In review in WIP Tracker Sep 29, 2024
droidmonkey added a commit that referenced this issue Oct 1, 2024
* Fixes #11044 - password generator excluded characters tooltip was incorrect

* Fixes #11084 - allow more than 30 days for showing expiring passwords. Also fix the ability to properly translate this control.

* Fixes #11212 - don't show password on creating new database

* Fixes #10726 - improve indication of hardware key polling. Also improve layout spacing of unlock dialog.

* Fixes #11142 - provide better link for challenge-response information
droidmonkey added a commit that referenced this issue Oct 7, 2024
* Fixes #11044 - password generator excluded characters tooltip was incorrect

* Fixes #11084 - allow more than 30 days for showing expiring passwords. Also fix the ability to properly translate this control.

* Fixes #11212 - don't show password on creating new database

* Fixes #10726 - improve indication of hardware key polling. Also improve layout spacing of unlock dialog.

* Fixes #11142 - provide better link for challenge-response information
@github-project-automation github-project-automation bot moved this from In review to Done in WIP Tracker Oct 7, 2024
droidmonkey added a commit that referenced this issue Oct 7, 2024
* Fixes #11044 - password generator excluded characters tooltip was incorrect

* Fixes #11084 - allow more than 30 days for showing expiring passwords. Also fix the ability to properly translate this control.

* Fixes #11212 - don't show password on creating new database

* Fixes #10726 - improve indication of hardware key polling. Also improve layout spacing of unlock dialog.

* Fixes #11142 - provide better link for challenge-response information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants