-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arbitrum testnet #822
Arbitrum testnet #822
Conversation
Hey @JSanchezFDZ, excited for this. Could you do me a favor and give us a bit more info on what to expect in this PR, at the business level? What are we trying to achieve here exactly? Also, is there an associated issue #? |
Hello @mhluongo! This is part of the project to be undertaken by Unknown Gravity to implement tBTC in Arbitrum. Here you can find all related information: https://www.notion.so/thresholdnetwork/tBTC-Native-Minting-on-Arbitrum-SDK-c0ac78cb258548e6b98cd463a4761c42?pvs=4 It was decided not to move forward with "gassless minting", so we followed the structure that was already develop for the BASE L2 blockchain: #792 Actually the structure developed by Lukasz is fully functional, we just enable and configure everything necessary to work with Arbitrum testnet. There are no additional developments. |
I've reviewed the changes and they follow along with the changes @lukasz-zimnoch did for Base. I've not been able to test the changes themselves as I don't have an environment set up for that yet. |
LGTM |
Looks good to me but some CI checks are failing. Once they are fixed, I'll be happy to approve and merge! |
Hello @lukasz-zimnoch! One of the errors was to modify the cross-chain folder, in which the SDK is not included. I think everything should be correct now. |
This is something I missed during the review of PR #825 adding the getDepositStatus function. The version should stay on 2.5.0-dev as this is the -dev version automatically pushed to the NPM registry and the last published non-dev version was 2.4.1. The next published non-dev release should be 2.5.0. I have also sneaked in docs regenerate change to fix the problem with a link that got updated in a fork with changes merged to this repository in #825 and #822.
This pull request introduces the implementation of Arbitrum Sepolia, using the development of the BASE blockchain as a foundation. The following changes have been made:
Added: