Update system tests to the new version of tbtc-v2.ts #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszslabon
force-pushed
the
system-test-update
branch
from
c4b656c to
b033e84
Compare
tomaszslabon
force-pushed
the
system-test-update
branch
from
d23b367 to
a759c41
Compare
tomaszslabon
force-pushed
the
system-test-update
branch
2 times, most recently
from
05e511c to
664b448
Compare
tomaszslabon
force-pushed
the
system-test-update
branch
from
664b448 to
198cbed
Compare
lukasz-zimnoch
requested changes
Nov 9, 2023
There was a problem hiding this comment.
One of the goals of this migration is testing the new API of the SDK v2. I'm afraid we are not making that with the presented changes. We are just using renamed components but keeping the old way of doing things. Left some comments that explain the intended direction:
tomaszslabon
force-pushed
the
system-test-update
branch
from
db36a1e to
db9632a
Compare
tomaszslabon
force-pushed
the
system-test-update
branch
from
db9632a to
5691a18
Compare
tomaszslabon
commented
Nov 10, 2023
system-tests/package.json
Outdated
| @@ -18,7 +18,7 @@ | |||
| "test/**/*" | |||
| ], | |||
| "dependencies": { | |||
| "@keep-network/tbtc-v2.ts": "2.0.0-dev.0", | |||
| "@keep-network/tbtc-v2.ts": "^2.2.0", | |||
There was a problem hiding this comment.
Change to ^2.3.0 once 2.3.0 is available.
tomaszslabon
force-pushed
the
system-test-update
branch
from
e91376a to
ac85bbf
Compare
tomaszslabon
force-pushed
the
system-test-update
branch
from
12e215f to
42442d2
Compare
lukasz-zimnoch
previously approved these changes
Nov 14, 2023
lukasz-zimnoch
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Refs: #716.
This PR updates the version of
tbtc-v2.tsused for system tests.