Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK final touches: Use Hex wherever applicable #713

Closed
3 tasks done
lukasz-zimnoch opened this issue Oct 16, 2023 · 0 comments
Closed
3 tasks done

SDK final touches: Use Hex wherever applicable #713

lukasz-zimnoch opened this issue Oct 16, 2023 · 0 comments
Assignees
@tomaszslabon
Labels
🔌 typescript TypeScript library
Milestone
typescript/v2.1.0

Comments

@lukasz-zimnoch
Copy link
Member

lukasz-zimnoch commented Oct 16, 2023 •
edited
Loading

Depends on: #698

As pointed out in the TODO, we need to inspect the public components of the typescript library and replace all string representing hexadecimal data with Hex. This way we will make the API consistent and more friendly as the clients would not have to wonder about using the right string format.

Tasks
Beta Give feedback
  1. Use Hex for arguments and return values #709
    🔌 typescript
    tomaszslabon
  2. Replaced string with Hex #723
    🔌 typescript
    tomaszslabon
@lukasz-zimnoch lukasz-zimnoch mentioned this issue Oct 16, 2023
Closed
@lukasz-zimnoch lukasz-zimnoch added the 🔌 typescript TypeScript library label Oct 16, 2023
@lukasz-zimnoch lukasz-zimnoch mentioned this issue Oct 16, 2023
Merged
@tomaszslabon tomaszslabon mentioned this issue Oct 25, 2023
Merged
lukasz-zimnoch added a commit that referenced this issue Oct 25, 2023
@lukasz-zimnoch
Replaced string with Hex (#723)
adca21f 
Refs: #713.
This PR replaces string with Hex for function arguments and return
values in order to unify library interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomaszslabon tomaszslabon

Labels
🔌 typescript TypeScript library
Projects
None yet
Milestone
typescript/v2.1.0
Development

No branches or pull requests
2 participants
@lukasz-zimnoch @tomaszslabon