You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks like Jailbreak detection was added to the library and will cause it to crash if on a jailbroken phone. This is unexpected, hidden and not documented.
This is now blocking the main thread for ~2 seconds every-time the wallet object is created. Our security audit instructed us to not keep this object in memory, meaning we have to re-create it for every transaction or network query. This is now adding a long delay and necessitating re-writes to complicated logic.
While I agree jailbreaking poses risks. I'm not sure I agree that TezosKit should be making a decision as to whether the app can run on a jailbroken phone or not. We were considering showing a message in our app. Either informing the user that they are not allowed to continue, or telling them the risks before continuing. But now the app crashes, without warning or instructions to the user.
I think it would be better to do one of the following:
Break this out as a separate function that apps can chose when/where/if to call themselves
Make it configurable
Run it on the Background thread to not forcibly block the main thread, and throw an error rather than crash
The text was updated successfully, but these errors were encountered:
Seems the jailbreak detection isn't blocking the main thread. I assumed it was, as it was the only change I noticed. Either the SecretKey or PublicKey creation in the Wallet is now blocking the main thread. Maybe consider making it Async
Looks like Jailbreak detection was added to the library and will cause it to crash if on a jailbroken phone. This is unexpected, hidden and not documented.
This is now blocking the main thread for ~2 seconds every-time the wallet object is created. Our security audit instructed us to not keep this object in memory, meaning we have to re-create it for every transaction or network query. This is now adding a long delay and necessitating re-writes to complicated logic.
While I agree jailbreaking poses risks. I'm not sure I agree that TezosKit should be making a decision as to whether the app can run on a jailbroken phone or not. We were considering showing a message in our app. Either informing the user that they are not allowed to continue, or telling them the risks before continuing. But now the app crashes, without warning or instructions to the user.
I think it would be better to do one of the following:
The text was updated successfully, but these errors were encountered: