-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplication and inconsistencies exist across different documentation subprojects #3586
Comments
Agreed. However, does it make sense to wait and make the theme based on docs redesign or can we make a theme now for what we have and then upgrade it? And, also, who makes this theme -- is it front end work for the Viz developers? |
For clarity, we wouldn't be crafting anything new: just packing our existing Then that pip-installable package gives us the foundation to make any actual modifications to the theme itself. |
More inconsistencies across projects: kedro-org/kedro-viz#1734 |
I opened a PR in the brand identity repo to solve this first point: kedro-org/kedro-brand-identity#7 |
Okay, it's happening https://github.com/kedro-org/kedro-sphinx-theme |
Adding this to our backlog so we can prioritize accordingly. |
Waiting for reviews on #3675 |
This has now been addressed across all 3 subprojects. Closing. |
Follow-up #3864 |
Description
We are starting to have lots of duplicated work across our 3 subprojects: core, viz, and datasets. This includes
Cmd+K
as a keyboard shortcut for searchContext
This situation is starting to pose some problems. For example, now making small adjustments to the CSS requires access to an object storage and they are not under version control. In addition, we now have inconsistent documentation dependencies across repositories, and maintaining them in sync is a burden.
We'd need to tackle this before #4257.
Possible Implementation
Create a custom Sphinx theme, so we can do
And that already contains everything we need.
Possible Alternatives
❓
The text was updated successfully, but these errors were encountered: