-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align slicing pipeline behavior between Kedro Viz and Kedro Framework #2187
Comments
Crazy idea - you could run pyodide and just run Kedro in the browser and not reimplement the logic |
I discussed this with @idanov, and here are the key takeaways:
|
Annoyingly we can't install Kedro on Pyodide because of OmegaConf's use of the ANTLR C library.
|
We'll have a TD session about this. |
Some early thoughts: it will probably make sense to split the use case between reporting and development. People navigating a pipeline will likely not be interested in the run command, whereas this will be useful information for people during the development phase. |
I really really recommend that people use dbt for a bit in anger, becasuse the tight linking between the CLI command and the UI is such a productivity boost. Sometimes we can just steal and take competitor/comparator validation in place of our own user research from first principles. |
I think the goal here is quite clear. The main blocker is how |
I like your suggestion to split the use cases between reporting and development @astrojuanlu . Here are some of my thoughts for further discussion in the TD
Since these features are not tightly coupled, I can see potential for reusing them in the VS Code extension as well. |
Description:
Ensure that the from-nodes and to-nodes slicing functionality behaves consistently across both the CLI and Viz interfaces.
Currently, Kedro Viz and the Kedro Framework do not behave in the same way, and not exactly what is described in the documentation for the slicing functionality
[SCREENSHOT 1]
For example:
When selecting from shuttles to combine step, Kedro Viz currently displays everything upwards from
combine step
(SCREENSHOT 1), with the run command shown in the kedro viz UI askedro run --to-nodes="combine step"
(SCREENSHOT 2 below) However Kedro Viz should ideally display only the nodes between from-nodes and to-nodes, such as from
companies
tocombine step
. I have created a quick proof of concept demonstrating how this can be achieved on the front-end. Therefore, the expected run command should bekedro run --from-nodes="companies" --to-nodes="combine step”.
[SCREENSHOT 2]
In the first MVP, we did not implement the full solution (SCREENSHOT 2) due to time constraints and potential CLI errors when attempting to execute a node that requires inputs that haven't been generated. Further discussion and details can be found here.
Task Scope
The goal of this task is to work with the Kedro Framework team to define the best approach for enabling Viz to work the same way as the Kedro Framework when running from-nodes and to-nodes. This will ensure consistent user experience across both interfaces.
Potential Solutions
There are two potential solutions identified:
kedro run --from-nodes="" --to-nodes=""
for the command that would trigger the error (e.g., kedro run --from-nodes="..." --to-nodes="...").kedro run --from-nodes --to-nodes
The text was updated successfully, but these errors were encountered: