You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From profiling various Kedro CLI commands, it turns out that a good chunk of the time is spent sending information to Heap in the before_command_run hook. This issue is to improve things on kedro-telemetry side.
Move to after_command_run hook, but this does not get executed if an exception occurs during the kedro run etc. The hook could be changed on the Kedro side to get executed even if the command fails.
Description
Follow up on kedro-org/kedro#1476
From profiling various Kedro CLI commands, it turns out that a good chunk of the time is spent sending information to Heap in the
before_command_run
hook. This issue is to improve things onkedro-telemetry
side.Context
kedro-org/kedro#1476 (comment)
kedro-org/kedro#1476 (comment)
Possible Implementations
after_command_run
hook, but this does not get executed if an exception occurs during thekedro run
etc. The hook could be changed on the Kedro side to get executed even if the command fails.pluggy
support async hook calls pytest-dev/pluggy#320Also to consider
There's some project hooks executed by
kedro-telemetry
too - we could figure out how to improve performance by not having to send this data twiceThe text was updated successfully, but these errors were encountered: