From c045c8b66b7401c385be93a2143ac82ced72282d Mon Sep 17 00:00:00 2001 From: Adarsh-verma-14 Date: Fri, 27 Oct 2023 19:08:09 +0530 Subject: [PATCH 1/2] add disable-compression arg for both operator and metrics-server Signed-off-by: Adarsh-verma-14 --- keda/templates/manager/deployment.yaml | 1 + keda/templates/metrics-server/deployment.yaml | 1 + keda/values.yaml | 4 ++++ 3 files changed, 6 insertions(+) diff --git a/keda/templates/manager/deployment.yaml b/keda/templates/manager/deployment.yaml index b993ae94..1eae0157 100644 --- a/keda/templates/manager/deployment.yaml +++ b/keda/templates/manager/deployment.yaml @@ -76,6 +76,7 @@ spec: - "/keda" args: - "--leader-elect" + - "--disable-compression={{ .Values.operator.disableCompression}}" - "--zap-log-level={{ .Values.logging.operator.level }}" - "--zap-encoder={{ .Values.logging.operator.format }}" - "--zap-time-encoding={{ .Values.logging.operator.timeEncoding }}" diff --git a/keda/templates/metrics-server/deployment.yaml b/keda/templates/metrics-server/deployment.yaml index ed5cf934..acf79140 100644 --- a/keda/templates/metrics-server/deployment.yaml +++ b/keda/templates/metrics-server/deployment.yaml @@ -123,6 +123,7 @@ spec: - --secure-port={{ .Values.service.portHttpsTarget }} - --logtostderr=true - --stderrthreshold={{ .Values.logging.metricServer.stderrthreshold }} + - --disable-compression={{ .Values.metricsServer.disableCompression}} - --metrics-service-address={{ .Values.operator.name }}.{{ .Release.Namespace }}.svc.{{ .Values.clusterDomain }}:9666 - --client-ca-file={{ .Values.certificates.mountPath }}/ca.crt - --tls-cert-file={{ .Values.certificates.mountPath }}/tls.crt diff --git a/keda/values.yaml b/keda/values.yaml index 39b7973a..f8b36473 100644 --- a/keda/values.yaml +++ b/keda/values.yaml @@ -44,6 +44,8 @@ operator: # You can run multiple replicas, but they will not improve the performance of KEDA, it could only reduce downtime during a failover. # Learn more in [our documentation](https://keda.sh/docs/latest/operate/cluster/#high-availability). replicaCount: 1 + # --Disable response compression for k8s restAPI in client-go. + disableCompression: true # -- [Affinity] for pod scheduling for KEDA operator. Takes precedence over the `affinity` field affinity: {} # podAntiAffinity: @@ -78,6 +80,8 @@ metricsServer: # You can run multiple replicas, but they will not improve the performance of KEDA, it could only reduce downtime during a failover. # Learn more in [our documentation](https://keda.sh/docs/latest/operate/cluster/#high-availability). replicaCount: 1 + # --Disable response compression for k8s restAPI in client-go. + disableCompression: true # use ClusterFirstWithHostNet if `useHostNetwork: true` https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy # -- Defined the DNS policy for the metric server dnsPolicy: ClusterFirst From 1c4154ad9902b567b182a22f6a10d5ed562af791 Mon Sep 17 00:00:00 2001 From: Adarsh-verma-14 Date: Fri, 17 Nov 2023 10:42:34 +0530 Subject: [PATCH 2/2] add explanation for disableCompression Signed-off-by: Adarsh-verma-14 --- keda/values.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/keda/values.yaml b/keda/values.yaml index f8b36473..b11c1b9b 100644 --- a/keda/values.yaml +++ b/keda/values.yaml @@ -45,6 +45,7 @@ operator: # Learn more in [our documentation](https://keda.sh/docs/latest/operate/cluster/#high-availability). replicaCount: 1 # --Disable response compression for k8s restAPI in client-go. + # Disabling compression simply means that turns off the process of making data smaller for K8s restAPI in client-go for faster transmission. disableCompression: true # -- [Affinity] for pod scheduling for KEDA operator. Takes precedence over the `affinity` field affinity: {} @@ -81,6 +82,7 @@ metricsServer: # Learn more in [our documentation](https://keda.sh/docs/latest/operate/cluster/#high-availability). replicaCount: 1 # --Disable response compression for k8s restAPI in client-go. + # Disabling compression simply means that turns off the process of making data smaller for K8s restAPI in client-go for faster transmission. disableCompression: true # use ClusterFirstWithHostNet if `useHostNetwork: true` https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy # -- Defined the DNS policy for the metric server