-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vpa crs for keda-operator and metrics-server #562
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: QuantumEnigmaa <[email protected]>
I just noticed I forgot to sign my 2 previous commits :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the new artifacts please?
Signed-off-by: QuantumEnigmaa <[email protected]>
@tomkerkhove I reverted the changes on the artefacts |
@@ -109,6 +109,11 @@ their default values. | |||
|
|||
| Parameter | Type | Default | Description | | |||
|-----------|------|---------|-------------| | |||
| `autoscaling.verticalPodAutoscaler.keda.cpu.maxAllowed` | int | `2` | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is automatically generated though: https://github.com/kedacore/charts/blob/main/CONTRIBUTING.md#documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean I can get rid of this change in the PR as it will be automatically be run by the ci jobs ?
I think that this is fascinating, but I'm not sure if it works correctly before the live pod resizing is in GA. I mean, restarting the operator for updating the pod size could produce scaling downtimes and we should clarify it IMHO. This also could generate impact on k8s api server on huge clusters if the VPA scales the pod so often because all the scalers cache has to be rebuilt on each restart, recovering all the needed info from the cluster |
This PR adds VPA CRs for both
keda-operator
andmetrics-server
.Checklist
Fixes #