Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btrfs restore prints "offset is " messages, even without verbose option #920

Open
keestux opened this issue Nov 7, 2024 · 0 comments
Open
Labels
bug UI/UX User interface change

Comments

@keestux
Copy link

keestux commented Nov 7, 2024

When I run btrfs restore without verbose option it prints lines like these:

$ sudo btrfs restore --root 4339 --snapshots --metadata --symlinks --ignore-errors /dev/sdc2 /tmp/my-restored-subvol
offset is 4096
offset is 8192
offset is 36864
offset is 4096
offset is 53248
offset is 4096

There is no documentation what these messages mean. Is it an error? Is it a message that should only be given with verbose option?

It is from line 394 in cmds/restore.c

	pr_verbose(offset ? 1 : 0, "offset is %llu\n", offset);

Perhaps the 1 should probably have been LOG_INFO. No?

Besides, it would be useful for the user to know what this message means.

@kdave kdave added bug UI/UX User interface change labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug UI/UX User interface change
Projects
None yet
Development

No branches or pull requests

2 participants