Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkfs --subvol fixups #898

Open
kdave opened this issue Sep 25, 2024 · 0 comments
Open

mkfs --subvol fixups #898

kdave opened this issue Sep 25, 2024 · 0 comments

Comments

@kdave
Copy link
Owner

kdave commented Sep 25, 2024

There are some fixups needed for the mkfs --subvol interface and some code cleanups. They should be separate patches on top of current code in devel (the hardlink code depends on that so we don't want to revert the changes). This issue tracks what needs to be done.

Syntax of --subvol:

mkfs --subvol SPEC

SPEC := [ TYPE ] path
TYPE := "default:" | "ro:" | "rw:" | "default-ro:"

Todo:

  • docs: update according to the new syntax
  • docs: mention that path that could match the type prefix can be worked around by ./
  • update tests, cover all options, also with the hardlink support

Code style and API fixes:

  • use path_ api for path manipulation, don't use dynamic allocation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant