Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Read the environment variables through option("PATH") in KRM KCL Spec #27

Closed
Peefy opened this issue Jan 23, 2024 · 7 comments · Fixed by #28
Closed

[Enhancement] Read the environment variables through option("PATH") in KRM KCL Spec #27

Peefy opened this issue Jan 23, 2024 · 7 comments · Fixed by #28
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Peefy
Copy link
Contributor

Peefy commented Jan 23, 2024

No description provided.

@Peefy Peefy added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 23, 2024
@satyazzz123
Copy link
Contributor

Hello @Peefy can I give this issue a try?

@Peefy
Copy link
Contributor Author

Peefy commented Jan 23, 2024

Hello @Peefy can I give this issue a try?

Hello @satyazzz123. Thank you for taking note of this issue. You can directly open a PR to complete the corresponding features. If you have any questions, please feel free to contact me at any time.

@satyazzz123
Copy link
Contributor

Hello @Peefy can I give this issue a try?

Hello @satyazzz123. Thank you for taking note of this issue. You can directly open a PR to complete the corresponding features. If you have any questions, please feel free to contact me at any time.

Thanks @Peefy . Sure,I am working on the PR

@satyazzz123
Copy link
Contributor

satyazzz123 commented Jan 23, 2024

Hello @Peefy , I had a question how is krm-kcl able to implement this logic-

Read resources from option("resource_list"). The option("resource_list") complies with the [KRM Functions Specification](https://github.com/kubernetes-sigs/kustomize/blob/master/cmd/config/docs/api-conventions/functions-spec.md#krm-functions-specification). You can read the input resources from option("items") and the functionConfig from option("functionConfig").

How KCL script is able to read a list of resources from an option named like "resource_list". I just need a overview of the working logic behind this functionality

@Peefy
Copy link
Contributor Author

Peefy commented Jan 23, 2024

You can see the logic here: https://github.com/kcl-lang/krm-kcl/blob/main/pkg/edit/bootstrap.go#L108

@satyazzz123
Copy link
Contributor

Thank you @Peefy , I just had a question. I found Read the OpenAPI schema. e.g. option("open_api")["definitions"]["io.k8s.api.apps.v1.Deployment"] . is in not yet implemented state , if its not an issue can I open a PR to address that ?

@Peefy
Copy link
Contributor Author

Peefy commented Jan 23, 2024

Thank you @Peefy , I just had a question. I found Read the OpenAPI schema. e.g. option("open_api")["definitions"]["io.k8s.api.apps.v1.Deployment"] . is in not yet implemented state , if its not an issue can I open a PR to address that ?

Sure! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants