Gh pages #11
Open
Gh pages #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added h1 Company Name, stylized Added ul li nav bar
Adjusted CSS and Stylesheet to match PSD document.
Both pages ready for desktop but MQ hasn’t been touched yet
Included white top/bottom border around gray boxes.
|
Thanks 👍 |
Closed
Footer work on both media queries
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
|
|
||
| <!-- MAIN CSS --> | ||
| <link href="style.css" rel="stylesheet" type="text/css"> |
There was a problem hiding this comment.
I see you're using two different stylesheets for your home & about page. It's not necessary to use two, it would be better to use one stylesheet, that way you can reuse styles, & it will be easier to maintain.
This style.css is referencing about/style.css. Having two stylesheets means you have to maintain both home & about page css. For example, your home page navigation looks good while resizing the browser but you would also need to apply those styles to your about/style.css. In the long run, when you start adding more pages, this will be much harder to maintain.
added 2 commits
March 29, 2016 08:31
linked home + about page fixed mobile + tablet view on about page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not gh-branches