Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the run manager #112

Open
3 of 10 tasks
ThibeauWouters opened this issue Jul 26, 2024 · 3 comments
Open
3 of 10 tasks

Update the run manager #112

ThibeauWouters opened this issue Jul 26, 2024 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@ThibeauWouters
Copy link
Collaborator

ThibeauWouters commented Jul 26, 2024

Here is some things we might want to add to the run manager:

  • Compute the SNR and save it somewhere.
  • Maybe add support for an SNR threshold, to skip injections below this threshold. See this example script
  • Add support to randomly sample injection parameters from the given prior ranges if no injection parameters are given.
  • Plotting functionalities (see Updating run-manager #107 for work in progress)
  • Add functionality to save everything in the runmanager: hyperparameters, save the output chains separately.
  • Add flexible functionality for loading from other RunManagers, e.g., load the injection parameters of a previous run in case the user wants to play around with hyperparameters on a specific injection
  • Add command line functionalities (see Command line tools for runs. #18 as well)
  • Check how to handle real GW events, load data, preprocess it et cetera.
  • Add dedicated examples of the runmanager
  • Add functionality to for doing multiple event runs in a batch (see Adding MultipleEventPERunManager #145 )
@ThibeauWouters ThibeauWouters added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 26, 2024
@xuyuon xuyuon moved this to In Progress in Jim-v1.0.0 Jul 26, 2024
@zipengwang98 zipengwang98 self-assigned this Jul 31, 2024
@zipengwang98
Copy link
Collaborator

pushed a new commit that stores SNR

@ThibeauWouters
Copy link
Collaborator Author

@zipengwang98 where exactly? I don't see it

@thomasckng
Copy link
Collaborator

I think he meant this commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: In Progress
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants