Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Craft 4 support? #5

Open
timeverts opened this issue May 10, 2022 · 12 comments
Open

Craft 4 support? #5

timeverts opened this issue May 10, 2022 · 12 comments

Comments

@timeverts
Copy link

Hi @kayqq and @simeon-smith,

Do you have any plans to port this plugin to Craft 4?

Thanks.

@ctangney-tulip
Copy link
Contributor

@timeverts @kayqq I've updated the code for use with Craft 4.

Shall I open a PR, or would it be more advisable to fork this? Not certain what your capacity for maintaining this is @kayqq

@nabilfreeman
Copy link

@timeverts @ctangney-tulip +1 for an update to this 😇

If you would be so kind, I think even just a PR would very useful for those of us comfortable with patches!

@timeverts
Copy link
Author

Great work @ctangney-tulip.

@kayqq and @simeon-smith, are you open and able to merge in a pull request and release a new version of the plugin? Or do you prefer that @ctangney-tulip release a brand new Craft 4 plugin based on the updated supporting code?

@ctangney-tulip
Copy link
Contributor

@timeverts @nabilfreeman I have not yet heard back from @kayqq regarding his preference on maintaining this code.

Our use-case required use to invalidate multiple versions of the path on entry save, so I have also added basic support for invalidation of patterns, based on the entry being saved. An example of this would be something like:

  • /the-entry
  • /the-entry/

More than happy to open a PR for this! If necessary, I can also fork this repository such that the code is available. Perhaps @simeon-smith has some input on this?

@ctangney-tulip
Copy link
Contributor

Completing the circle of references: #6

@kayqq
Copy link
Owner

kayqq commented Jun 12, 2023

I dont have capacity anymore to support this plugin but am happy to add new owners to this.

I merged #6 in. Hopefully that resolves your issue @ctangney-tulip @nabilfreeman @timeverts

@timeverts
Copy link
Author

Thanks for providing an update @kayqq.

The merge into master was helpful, but to be honest, there's a bit more to do to release this as a Craft 4 plugin into the plugin store.

@ctangney-tulip, if you're familiar with the process to create a new plugin, and if @kayqq is happy to transfer ownership of the repository to you, I'd suggest that. Then you can make the final changes and release it to the Craft 4 plugin store.

@nabilfreeman
Copy link

Thank you all, it's so encouraging to see speedy action on projects like this! Really genuinely appreciate it 👏👏👏👏👏👏

@ctangney-tulip
Copy link
Contributor

@timeverts agreed -- still a good bit to do in order to get this published. This was ultimately a quick / dirty hot-fix to get things working for our needs.

I will discuss with my team the possibility of taking ownership of this plugin. Our bandwidth is limited for the moment, but it might be something I can attempt to support in a personal capacity.

I do not use Craft in my personal projects, nor do I have access to an instance outside of my organization. This would ultimately make personal ownership a little tricky for me to sign up for 😞

@kayqq
Copy link
Owner

kayqq commented Jun 13, 2023

Should be on the Craft 4 store now

@nabilfreeman
Copy link

@kayqq LEGEND 🚀 🎉 🎊

@ctangney-tulip
Copy link
Contributor

@kayqq do you have an email that would work for me to contact you at with some questions regarding ownership of this codebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants