-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributing guidelines #758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you!
I have one question. docs/index.rst
is not displayed well as an rst
file via Github platform but I suppose it looks well when opening in the browser?
Is there a build script that runs upon merge to main? |
I believe that everything that runs is described here in the workflows https://github.com/kayak/pypika/tree/master/.github/workflows. Only a linting process and a testing process in various Python versions is done |
Thats what I made of it too. Are the docs build manual then? |
It seems to be so currently |
Confirmed here |
I've added a bit more to the CONTRIBUTING.rst as well as added support for numpy style docstrings (raised by me) I have successful builds locally but with handful of warnings:
|
Ended up adding the missing modules (but didn't explore |
Looks good |
Contributing guidelines (kayak#758)
Adding some information about how to contributing to PyPika after the conversation in this Issue.
I've added a CONTRIBUTING document that will be linked in the docs that build (where do these update by the way?)
Any feedback on content would be helpful!
I just added a few items based on setting up the environment and running tests but this is very flexible.
Does anyone know how to have a checklist added to a new PR via a GitHub action? Maybe a checklist or a link to this documentation would be reminder if the automation is easy to setup
Overall, I hope this helps standardize some of the steps while contributing.