We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL identifier names are not being escaped, thus enabling SQL injection attacks.
Here is a minimal example to reproduce:
import pypika table = pypika.Table('my_table"--') field = getattr(table, 'my_field"--') builder = ( pypika.Query.from_(table, dialect=pypika.Dialects.POSTGRESQL) .select(field) .where(table.name == "value'") ) print(builder)
This code produces the following SQL, where single quotes are correctly being escaped but double quotes are not:
SELECT "my_field"--" FROM "my_table"--" WHERE "name"='value'''
The text was updated successfully, but these errors were encountered:
Doesn't seem ideal. Would you like to make a PR and write some tests against this behavior?
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
SQL identifier names are not being escaped, thus enabling SQL injection attacks.
Here is a minimal example to reproduce:
This code produces the following SQL, where single quotes are correctly being escaped but double quotes are not:
The text was updated successfully, but these errors were encountered: