Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hours in which user like to post is added #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ayushpatidar
Copy link

@ayushpatidar ayushpatidar commented Jan 19, 2019

Description

In this pull request, I have added the functionality in which it shows at which hours in a day is a user most likely to post

Fixes # [ISSUE]

Type of Change:

Delete irrelevant options.
Code

Code/Quality Assurance Only

  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

python time_user_post.py

Checklist:

Delete irrelevant options.

  • [* ] I have ensured my PR satisfies the checklist mentioned in CONTRIBUTING.md.
  • [*] My PR follows the style guidelines of this project
  • [*] I have performed a self-review of my own code or materials
  • [* ] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • [* ] My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • [* ] Any dependent changes have been published in downstream modules

Copy link
Owner

@kaustubhhiware kaustubhhiware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayushpatidar thanks for contributing 😄

Could you add some images of the plots generated by this script ?

Have a look at #21 for a sample PR.

@xprilion xprilion removed their request for review January 20, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants